build: implement JSON-driven Android patch system#59543
Open
lluisemper wants to merge 1 commit intonodejs:mainfrom
Open
build: implement JSON-driven Android patch system#59543lluisemper wants to merge 1 commit intonodejs:mainfrom
lluisemper wants to merge 1 commit intonodejs:mainfrom
Conversation
lluisemper
force-pushed
the
build-json-android-patches
branch
from
f1a42e1 to
a0528fc
Compare
Replace hardcoded Android patch application with JSON configuration to improve maintainability and enable multiple patches. The current patch_android() function only applies a single hardcoded patch, making it difficult to add new patches needed for Android builds. Recent contributions show multiple patches are required for proper Android cross-compilation support. This change: - Creates android-patches.json for patch configuration - Refactors patch_android() to read from JSON - Enables platform-specific patch filtering - Maintains 100% backward compatibility - Prepares infrastructure for additional patches Implements TODO comment in android_configure.py line 5 Refs: nodejs#57748
lluisemper
force-pushed
the
build-json-android-patches
branch
from
a0528fc to
118a8da
Compare
Contributor
|
This pull request has been marked as stale due to 210 days of inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded Android patch application with JSON configuration to improve maintainability and enable multiple patches.
The current patch_android() function only applies a single hardcoded patch, making it difficult to add new patches needed for Android builds. Recent contributions show multiple patches are required for proper Android cross-compilation support.
This change:
Implements TODO comment in android_configure.py line 5
Refs: #57748